Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions internal/engine/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import (
"path/filepath"

"github.com/chojs23/ec/internal/cli"
"github.com/chojs23/ec/internal/gitmerge"
"github.com/chojs23/ec/internal/markers"
"github.com/chojs23/ec/internal/mergeview"
)

func CheckResolvedFile(mergedPath string) (bool, error) {
Expand Down Expand Up @@ -46,11 +46,7 @@ func ApplyAllAndWrite(ctx context.Context, opts cli.Options) error {
return nil
}

mergeViewBytes, err := gitmerge.MergeFileDiff3(ctx, opts.LocalPath, opts.BasePath, opts.RemotePath)
if err != nil {
return err
}
viewDoc, err := markers.Parse(mergeViewBytes)
viewDoc, err := mergeview.LoadCanonicalDocument(ctx, opts)
if err != nil {
return err
}
Expand Down
55 changes: 55 additions & 0 deletions internal/engine/engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,61 @@ func TestApplyAllAndWrite_NoConflictsNoWrite(t *testing.T) {
}
}

func TestApplyAllAndWriteUsesCanonicalThreeWayInputsOverMergedMarkers(t *testing.T) {
if testing.Short() {
t.Skip("skipping integration-style test in short mode")
}
if _, err := exec.LookPath("git"); err != nil {
t.Skip("git not found in PATH")
}

ctx := context.Background()
tmpDir := t.TempDir()

basePath := filepath.Join(tmpDir, "base.txt")
localPath := filepath.Join(tmpDir, "local.txt")
remotePath := filepath.Join(tmpDir, "remote.txt")
mergedPath := filepath.Join(tmpDir, "merged.txt")

baseContent := "line1\nbase content\nline3\n"
localContent := "line1\nlocal change\nline3\n"
remoteContent := "line1\nremote change\nline3\n"
mergedContent := "line1\n<<<<<<< ours-label\nlocal from merged marker\n=======\nremote from merged marker\n>>>>>>> theirs-label\nline3\n"

if err := os.WriteFile(basePath, []byte(baseContent), 0o644); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(localPath, []byte(localContent), 0o644); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(remotePath, []byte(remoteContent), 0o644); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(mergedPath, []byte(mergedContent), 0o644); err != nil {
t.Fatal(err)
}

opts := cli.Options{
BasePath: basePath,
LocalPath: localPath,
RemotePath: remotePath,
MergedPath: mergedPath,
ApplyAll: "ours",
}

if err := ApplyAllAndWrite(ctx, opts); err != nil {
t.Fatalf("ApplyAllAndWrite failed: %v", err)
}

resolved, err := os.ReadFile(mergedPath)
if err != nil {
t.Fatal(err)
}
if string(resolved) != localContent {
t.Fatalf("resolved output mismatch: got %q want %q", string(resolved), localContent)
}
}

func TestCheckResolvedFile(t *testing.T) {
tmpDir := t.TempDir()

Expand Down
Loading