just a few changes/additions#5
Open
copypastedeveloper wants to merge 7 commits intochoonkeat:masterfrom
Open
Conversation
…h of the dropdown, fleshed out topOffset and leftOffset, reworked the way the configuration is merged together to better handle defaults.
…accidentally removed.
…select list to be smaller than the styled elements.
Conflicts: jquery.yaselect.js jquery.yaselect.min.js
Owner
|
Hi ncgonz, Thanks for your patch! There's a few things I need your help with though,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i've merged in your latest change, so this should be definitive. i made a few changes to allow for something i needed, as well as setting up what i think is a better way to configure the options. also added a couple of features i thought were there but were not.