Skip to content

Dev #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
choubung merged 2 commits into from
Nov 18, 2025
Merged

Dev #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ae2aa
chore: application.propertise 배포용과 개발용 분리
choubung Nov 18, 2025
cefb390
Merge pull request #47 from choubung/hot-fix/ver1-1
choubung Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/resources/application-prod.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
spring.datasource.url=${DB_URL}
spring.datasource.username=${DB_USERNAME}
spring.datasource.password=${DB_PASSWORD}
Comment on lines +1 to +3
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

PR 목표와 모순되는 환경 변수 사용.

PR 목표("명시적 하드코딩된 설정으로 변경")에 따르면, 환경 변수 기반 설정을 제거해야 합니다. 그러나 프로덕션 설정 파일은 여전히 ${DB_URL}, ${DB_USERNAME}, ${DB_PASSWORD} 환경 변수를 사용하고 있습니다. application.properties에서 H2 데이터베이스는 명시적으로 하드코딩되어 있는 반면, 이 파일은 환경 변수를 유지하고 있어 일관성이 없습니다.

명시적 값으로 변경할 의도가 있다면 프로덕션 환경의 실제 데이터베이스 자격증명으로 대체하거나, 환경 변수 방식을 계속 사용할 계획이라면 PR 목표와 구현을 정렬하시기 바랍니다.

🤖 Prompt for AI Agents 
In src/main/resources/application-prod.properties lines 1-3, the file still uses
environment variable placeholders (${DB_URL}, ${DB_USERNAME}, ${DB_PASSWORD})
which conflicts with the PR goal of switching to explicit hardcoded settings;
either replace these placeholders with the actual production JDBC URL, username,
and password values (hardcoded) to match the other properties, or update the PR
goal/description to accept environment-variable configuration and keep the
placeholders; ensure whichever path you choose results in consistent
configuration across application.properties and application-prod.properties and
does not leave mixed approaches.

spring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver

# --- ???? JPA (Hibernate) ---
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

주석의 깨진 문자 수정 필요.

라인 6과 11의 주석에 한글이 제대로 인코딩되지 않아 물음표("????")로 표시되고 있습니다. 파일의 문자 인코딩을 확인하고 주석을 올바르게 수정하세요.

수정 제안:

-# --- ???? JPA (Hibernate) ---
+# --- 🔧 JPA (Hibernate) ---
-# --- ???? H2 ?? ---
+# --- 🔧 H2 콘솔 ---

Also applies to: 11-11

🤖 Prompt for AI Agents 
src/main/resources/application-prod.properties around lines 6 and 11: the
comment text contains broken characters ("????") due to wrong encoding; open the
file with UTF-8 encoding (or convert it to UTF-8), replace the corrupted comment
entries on lines 6 and 11 with the correct Korean text (e.g. "# --- JPA
(Hibernate) ---" or your intended Korean comment), save the file as UTF-8, and
ensure your editor/CI respects UTF-8 for properties files so the characters
remain intact.

spring.jpa.hibernate.ddl-auto=validate
spring.jpa.show-sql=false
spring.jpa.database-platform=org.hibernate.dialect.MySQLDialect

# --- ???? H2 ?? ---
spring.h2.console.enabled=false
16 changes: 10 additions & 6 deletions src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
spring.application.name=openMission
spring.profiles.include=oauth
server.port=${PORT:9090}

spring.datasource.url=${DB_URL:jdbc:h2:./mydb;AUTO_SERVER=TRUE}
spring.datasource.username=${DB_USERNAME:sa}
spring.datasource.password=${DB_PASSWORD:}
# --- ?? H2 Datasource ---
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

주석의 깨진 문자 수정 필요.

라인 4, 10, 16의 주석에 한글이 제대로 인코딩되지 않아 물음표("????")로 표시되고 있습니다. 파일의 문자 인코딩을 UTF-8로 설정하고 주석을 올바르게 수정하세요.

수정 제안:

-# --- ?? H2 Datasource ---
+# --- 🔧 H2 Datasource ---
-# --- ?? JPA (Hibernate) ---
+# --- 🔧 JPA (Hibernate) ---
-# --- ?? H2 ?? ---
+# --- 🔧 H2 콘솔 ---

Also applies to: 10-10, 16-16

🤖 Prompt for AI Agents 
In src/main/resources/application.properties around lines 4, 10 and 16, the
comment text contains garbled question marks due to wrong file encoding; open
the file with UTF-8 encoding (or convert it to UTF-8), replace the broken
comment characters with the intended Korean text, and save the file in UTF-8 so
the comments display correctly; ensure your editor/IDE and Git commit use UTF-8
(or add a .gitattributes entry to enforce text working-tree-encoding=utf-8 for
*.properties if needed).

spring.datasource.url=jdbc:h2:./mydb;AUTO_SERVER=TRUE
spring.datasource.driver-class-name=org.h2.Driver
spring.datasource.username=sa
spring.datasource.password=

# JPA (Hibernate)
# --- ?? JPA (Hibernate) ---
spring.jpa.hibernate.ddl-auto=update
spring.jpa.show-sql=true

# H2
spring.jpa.database-platform=org.hibernate.dialect.H2Dialect

# --- ?? H2 ?? ---
spring.h2.console.enabled=false
spring.h2.console.path=/h2-console
Loading