Open
Conversation
Closed
Owner
|
hi @jeanwire sorry delay, can you resolve the conflict? |
|
Hey @jeanwire are you still interested in getting this merged? Otherwise I'm happy to submit another PR resolving the conflicts. |
jeanwire
force-pushed
the
feat/add-testid-prop
branch
from
ed1ace4 to
3c0ebcf
Compare
Author
|
thanks for the ping @jeanregisser should be okay to merge now @chramos |
|
@chramos any chance this is getting merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a testID prop to
SkeletonPlaceholder. This makes unit testing this package more straightforward