Skip to content

Add the generic variant for NControlViewRenderer #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timotei wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add the generic variant for NControlViewRenderer #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions NControl.Win/NControlViewRendererBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,13 @@

namespace NControl.Win
{
public abstract class NControlViewRendererBase : NControlViewRendererBase<NControlView> { }

/// <summary>
/// NControlView renderer.
/// </summary>
public abstract class NControlViewRendererBase : ViewRenderer<NControlView, Border>
public abstract class NControlViewRendererBase<TNControlView> : ViewRenderer<TNControlView, Border>
where TNControlView : NControlView
{
/// <summary>
/// Used for registration with dependency service
Expand Down Expand Up @@ -70,7 +73,7 @@ public NControlViewRendererBase()
/// Raises the element changed event.
/// </summary>
/// <param name="e">E.</param>
protected override void OnElementChanged(ElementChangedEventArgs<NControlView> e)
protected override void OnElementChanged(ElementChangedEventArgs<TNControlView> e)
{
base.OnElementChanged(e);

Expand Down Expand Up @@ -262,7 +265,7 @@ uiElement is System.Windows.Controls.ListBox ||
}

// Are we interested?
var renderer = uiElement as NControlViewRendererBase;
var renderer = uiElement as NControlViewRendererBase<TNControlView>;
if (renderer == null)
continue;

Expand Down
7 changes: 5 additions & 2 deletions NControl/NControl.Droid/NControlViewRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,14 @@
[assembly: ExportRenderer(typeof(NControlView), typeof(NControlViewRenderer))]
namespace NControl.Droid
{
public class NControlViewRenderer : NControlViewRenderer<NControlView> { }

/// <summary>
/// NControlView renderer.
/// </summary>
[Preserve(AllMembers = true)]
public class NControlViewRenderer : VisualElementRenderer<NControlView>
public class NControlViewRenderer<TNControlView> : VisualElementRenderer<TNControlView>
where TNControlView : NControlView
{
/// <summary>
/// Used for registration with dependency service
Expand All @@ -56,7 +59,7 @@ public static void Init ()
/// Raises the element changed event.
/// </summary>
/// <param name="e">E.</param>
protected override void OnElementChanged(ElementChangedEventArgs<NControlView> e)
protected override void OnElementChanged(ElementChangedEventArgs<TNControlView> e)
{
base.OnElementChanged(e);

Expand Down
5 changes: 4 additions & 1 deletion NControl/NControl.WP80/NControlViewRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,13 @@
[assembly: ExportRenderer(typeof(NControlView), typeof(NControlViewRenderer))]
namespace NControl.WP80
{
public class NControlViewRenderer : NControlViewRenderer<NControlView> { }

/// <summary>
/// NControlView renderer.
/// </summary>
public class NControlViewRenderer : NControlViewRendererBase
public class NControlViewRenderer<TNControlView> : NControlViewRendererBase<TNControlView>
where TNControlView : NControlView
{
/// <summary>
/// Used for registration with dependency service
Expand Down
5 changes: 4 additions & 1 deletion NControl/NControl.WP81/NControlViewRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@
[assembly: ExportRenderer(typeof(NControlView), typeof(NControlViewRenderer))]
namespace NControl.WP81
{
public class NControlViewRenderer : NControlViewRenderer<NControlView> { }

/// <summary>
/// NControlView renderer.
/// </summary>
public class NControlViewRenderer: NControlViewRendererBase
public class NControlViewRenderer<TNControlView>: NControlViewRendererBase<TNControlView>
where TNControlView : NControlView
{
/// <summary>
/// Used for registration with dependency service
Expand Down
13 changes: 8 additions & 5 deletions NControl/NControl.iOS/NControlViewRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,14 @@
[assembly: ExportRenderer(typeof(NControlView), typeof(NControlViewRenderer))]
namespace NControl.iOS
{
/// <summary>
/// NControlView renderer.
/// </summary>
public class NControlViewRenderer : NControlViewRenderer<NControlView> { }

/// <summary>
/// NControlView renderer.
/// </summary>
[Preserve(AllMembers = true)]
public class NControlViewRenderer: VisualElementRenderer<NControlView>
public class NControlViewRenderer<TNControlView> : VisualElementRenderer<TNControlView>
where TNControlView : NControlView
{
/// <summary>
/// The gesture recognizer.
Expand All @@ -62,7 +65,7 @@ public class NControlViewRenderer: VisualElementRenderer<NControlView>
/// Raises the element changed event.
/// </summary>
/// <param name="e">E.</param>
protected override void OnElementChanged(ElementChangedEventArgs<NControlView> e)
protected override void OnElementChanged(ElementChangedEventArgs<TNControlView> e)
{
base.OnElementChanged(e);

Expand Down