Skip to content

Update deps, rust version and fix lints#63

Open
chris-zen wants to merge 1 commit intomasterfrom
update
Open

Update deps, rust version and fix lints#63
chris-zen wants to merge 1 commit intomasterfrom
update

Conversation

@chris-zen
Copy link
Owner

No description provided.

@chris-zen
Copy link
Owner Author

chris-zen commented Feb 13, 2026

@Boddlnagg @xtqqczze this should modernise the project a bit and remove the undefined behaviour from EventList and PacketList.

@xtqqczze
Copy link
Contributor

$ cargo clippy --all-targets --all-features --workspace
    Checking coremidi v0.9.0
warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
  --> examples/receive.rs:39:13
   |
39 | /             path.split(std::path::MAIN_SEPARATOR)
40 | |                 .last()
   | |__________________-----^
   |                    |
   |                    help: try: `next_back()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#double_ended_iterator_last
   = note: `#[warn(clippy::double_ended_iterator_last)]` on by default

warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
  --> examples/send.rs:39:13
   |
39 | /             path.split(std::path::MAIN_SEPARATOR)
40 | |                 .last()
   | |__________________-----^
   |                    |
   |                    help: try: `next_back()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#double_ended_iterator_last
   = note: `#[warn(clippy::double_ended_iterator_last)]` on by default

@xtqqczze
Copy link
Contributor

Update CI to run cargo clippy --workspace --all-targets --all-features -- -D warnings

run: cargo clippy -- -D warnings

@chris-zen
Copy link
Owner Author

Update CI to run cargo clippy --workspace --all-targets --all-features -- -D warnings

run: cargo clippy -- -D warnings

Is that really necessary? Currently I have cargo clippy --all-targets -- -D warnings, because this is not a workspace and there are no features.

@xtqqczze
Copy link
Contributor

Is that really necessary?

Including the extra flags here is mostly about future-proofing the CI. --all-targets is the important change.

@xtqqczze
Copy link
Contributor

fixed some ptr constness issues: 85e9d5f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants