Replace toInternalURL() with toURL() for Android#259
Open
mattkhaw wants to merge 1 commit intochrisben:masterfrom
Open
Replace toInternalURL() with toURL() for Android#259mattkhaw wants to merge 1 commit intochrisben:masterfrom
mattkhaw wants to merge 1 commit intochrisben:masterfrom
Conversation
When the plugin is used in newer versions of Android, it always uses toInternalURL() instead of toURL(). When using toInternalURL() for Android, the plugin is unable to download and save or retrieve any cache files since the url provided by toInternalURL() is invalid. By adding the above checking, this will solve the issue completely. Feel free to refactor the code if this fix doesn't apply to all scenarios tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the plugin is used in newer versions of Android, it always uses toInternalURL() instead of toURL(). When using toInternalURL() for Android, the plugin is unable to download and save or retrieve any cache files since the url provided by toInternalURL() is invalid.
By adding the above checking, this will solve the issue completely. Feel free to refactor the code if this fix doesn't apply to all scenarios tested.