Improve slave_running check #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code only consider condition Slave_SQL_Running is yes and then send slave_running equal 1. We should consider both of condition are Slave_IO_Running and Slave_SQL_Running to set the value of slave_running metric.
CharlesJUDITH
force-pushed
the
patch_slave_io_running
branch
from
72e83ed to
7b8c060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code only consider condition Slave_SQL_Running is yes and
then send slave_running equal 1. We should consider both of condition
are Slave_IO_Running and Slave_SQL_Running to set the value of
slave_running metric.