Skip to content

Dart compatibility updates for JSON decoding and Unit test signatures #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aggregat4 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dart compatibility updates for JSON decoding and Unit test signatures #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/parsers/config_parser_json.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
library config_parser_json;

import 'dart:async';
import 'dart:json' as JSON;
import 'dart:convert';

import '../config.dart';

Expand All @@ -10,7 +10,7 @@ class JsonConfigParser implements ConfigParser {
Future<Map> parse(String configText) {
var completer = new Completer<Map>();

var map = JSON.parse(configText);
var map = JSON.decode(configText);
completer.complete(map);

return completer.future;
Expand Down
4 changes: 2 additions & 2 deletions test/tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class MapMatcher implements Matcher {

// JSON parse the item back into a map, and compare the two maps
// (brute force, innefficient)
bool matches(Map item, MatchState matchState) {
bool matches(Map item, Map matchState) {
var result = true;

// try and compare the item and the map
Expand All @@ -120,7 +120,7 @@ class MapMatcher implements Matcher {
}

Description describeMismatch(item, Description mismatchDescription,
MatchState matchState, bool verbose) {
Map matchState, bool verbose) {
mismatchDescription.add("item: ${item.toString()}");
return mismatchDescription;

Expand Down