First stab at documentation#1
Open
geeksareforlife wants to merge 2 commits intochrisemerson:masterfrom
Open
Conversation
chrisemerson
requested changes
Jul 25, 2021
Owner
chrisemerson
left a comment
chrisemerson
left a comment
There was a problem hiding this comment.
Sorry it's taken so long to get around to this! Hope these comments make sense
Author
|
Same apology from me! Life gets in the way. Hope these changes work for you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still some bits to expand here.
I also think it makes sense to make the
rememberedLoginServicebe an optional third argument to theAuthclass. I have written the doc as if it is.