This repository was archived by the owner on Aug 22, 2025. It is now read-only.
Fixed #160 - Crash when using labelFor attribute#194
Open
kkoser wants to merge 1 commit intochrisjenx:masterfrom
Open
Fixed #160 - Crash when using labelFor attribute#194kkoser wants to merge 1 commit intochrisjenx:masterfrom
kkoser wants to merge 1 commit intochrisjenx:masterfrom
Conversation
Having a labelFor attribute was causing crashes in the CalligraphyFactory due to an uncaught ResourceNotFound exception. We should be catching this exception and treating it the same as if the view had NO_ID.
Owner
|
What does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a labelFor attribute was causing crashes in the CalligraphyFactory due to an uncaught ResourceNotFound exception. We should be catching this exception and treating it the same as if the view had NO_ID.