Skip to content

Fix Windows dissector install instructions #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tablackburn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Windows dissector install instructions #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tools/wireshark/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,17 @@ cp stagelinq.lua ~/.local/lib/wireshark/plugins/
```

### Windows
Copy `stagelinq.lua` to:

From Command Prompt:
```cmd
mkdir "%APPDATA%\Wireshark\plugins"
copy stagelinq.lua "%APPDATA%\Wireshark\plugins\"
Comment on lines +26 to +27
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy will prompt on overwrite in some scenarios, and mkdir will emit an “already exists” message when re-running the instructions. Consider making the Command Prompt steps explicitly idempotent (e.g., guard the mkdir with if not exist ... and use copy /Y if overwriting is acceptable) to avoid interactive prompts and reduce confusion when users rerun the steps.

Suggested change
mkdir "%APPDATA%\Wireshark\plugins"
copy stagelinq.lua "%APPDATA%\Wireshark\plugins\"
if not exist "%APPDATA%\Wireshark\plugins" mkdir "%APPDATA%\Wireshark\plugins"
copy /Y stagelinq.lua "%APPDATA%\Wireshark\plugins\"

Copilot uses AI. Check for mistakes.
```
%APPDATA%\Wireshark\plugins\

From PowerShell:
```powershell
New-Item -ItemType Directory -Force -Path "$env:APPDATA\Wireshark\plugins"
Copy-Item stagelinq.lua "$env:APPDATA\Wireshark\plugins\"
Comment on lines +32 to +33
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New-Item will print an object to the console by default, which can be distracting in copy/paste instructions. Consider suppressing that output (e.g., piping to Out-Null) to keep the instructions cleaner; similarly, if overwriting an existing stagelinq.lua is expected, consider using Copy-Item -Force to avoid prompts/errors.

Suggested change
New-Item -ItemType Directory -Force -Path "$env:APPDATA\Wireshark\plugins"
Copy-Item stagelinq.lua "$env:APPDATA\Wireshark\plugins\"
New-Item -ItemType Directory -Force -Path "$env:APPDATA\Wireshark\plugins" | Out-Null
Copy-Item stagelinq.lua "$env:APPDATA\Wireshark\plugins\" -Force

Copilot uses AI. Check for mistakes.
```

## Usage
Expand Down