Speed up SmoothNormals by ~2x and reduce memory allocation.#26
Open
benoithudson wants to merge 1 commit intochrisnolet:masterfrom
Open
Speed up SmoothNormals by ~2x and reduce memory allocation.#26benoithudson wants to merge 1 commit intochrisnolet:masterfrom
benoithudson wants to merge 1 commit intochrisnolet:masterfrom
Conversation
On my sample I see the time fall from 33ms to 16ms. Allocation falls from 500 kB to 380 kB. * Compute the deduplication by hand instead of using Linq (vast bulk of the improvement) * Average by dividing rather than normalizing (0.41ms to 0.06ms) * Don't add the first normal to zero, just assign it (0.16ms to 0.10ms)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my sample I see the time fall from 33ms to 16ms. Allocation falls from 500 kB to 380 kB.