Extract hardcoded window size constraints to named constants#6
Closed
Copilot wants to merge 3 commits intofeat/window-wrapperfrom
Closed
Extract hardcoded window size constraints to named constants#6Copilot wants to merge 3 commits intofeat/window-wrapperfrom
Copilot wants to merge 3 commits intofeat/window-wrapperfrom
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
Co-authored-by: christopher-ling <145088109+christopher-ling@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback from review on Feat/window wrapper PR
Extract hardcoded window size constraints to named constants
Dec 22, 2025
fe42c09 to
63767c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #5 to eliminate magic numbers for minimum window dimensions (300px width, 200px height) repeated across resize logic.
Changes
MIN_WINDOW_WIDTHandMIN_WINDOW_HEIGHTconstants tosrc/constants/index.jsWindowWrapper.jsxto import and use these constants instead of hardcoded values (6 occurrences replaced)Window resize constraints now centralized in constants file for consistent updates.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.