Bitwise logic operators for CNF-related types#618
Merged
Conversation
chrjabs
changed the title
This allows using `Var::vidx32` and `Var::new_unchecked`, as well as `Lit::lidx32` and `Lit::from_lidx` instead of the bitwise operations for advanced usage. Also frees up the operator trait implementations to be used for more convinient encoding implementations.
chrjabs
force-pushed
the
push-nqwwvskpqzko
branch
from
a8c9ff1 to
310029b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Contribution
Inspired by #613, this implements not (
!or-), or (|), and and (&) operators forVar,Lit,Clause,Cnf, andSatInstanceas applicable while staying within CNF.If we support general formulas in the future, the remaining operators can be implemented.
PR Checklist
CONTRIBUTING.mdrustfmt/cargo fmt --allnext-majorbranch, not againstmain