[b/505303589] Updated parser validation script#710
[b/505303589] Updated parser validation script#710prasoonbirla-google wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the parser validation script to improve test accuracy and debugging capabilities. By preserving the full UDM structure, dynamically resolving log types, and refining timestamp normalization, the changes reduce false-positive test failures and provide a more robust validation process for parser regressions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors timestamp normalization to handle microseconds, updates timestamp filtering, and introduces dynamic log type detection from a metadata file. It also simplifies the UDM event construction by nesting the original event under a new 'readOnlyUdm' key. Feedback includes a security concern regarding the use of 'json.loads' instead of 'yaml.safe_load' as per the style guide, a suggestion for more robust I/O error handling, and a note about missing logic for dumping validation results mentioned in the PR description.
Fix: Improve parser validation output structure and timestamp handling
Description
What problem does this PR solve?
This PR addresses several issues in the parser validation script (
run_parser_validations.py) to make test event comparisons more accurate and to improve debugging capabilities:metadataandadditional, which caused structure mismatches with the expectedtest_events.jsonfiles.log_typepassed to the validation API was hardcoded to a dummy value, which could affect parser routing or results..198Zvs.198000Z) and due to the diffing tool not ignoring the camelCaseeventTimestampfield when the year falls back to the current execution year.How does this PR solve the problem?
idm.readOnlyUdm(using camelCase as expected by the tests), ensuring fields likeprincipal,target, andobserverare correctly included in the validation phase.metadata.jsonin thecbndirectory and extracts the actuallogTypeto pass into ``chronicle_client.run_parser(), gracefully falling back to a default if unavailable.normalize_timestamp()to cleanly strip trailing zeros from microseconds, matching the canonical expected log format.filter_timestamps()to properly ignore the camelCaseeventTimestampfield during the symmetric diff, preventing false failures caused by fallback execution years.print(validation_results)statement with file I/O that cleanly dumps the API payload into avalidation_results.jsonfile in the same directory as the generated markdown report.Any other relevant information (e.g., design choices, tradeoffs, known issues):
The timestamp normalizer handles cases with and without existing milliseconds. By keeping the complete unmodified event mapped directly into
readOnlyUdm, the validation suite now acts as a much stricter and more accurate gate against parser regressions across all UDM fields.Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only:
Screenshots (If Applicable)
If your changes involve UI or visual elements, please include screenshots or GIFs here.
Ensure any sensitive data is redacted or generalized.
Further Comments / Questions
Any additional comments, questions, or areas where you'd like specific feedback.