Skip to content

1p tracking list filter fix env query#711

Open
timere-nemo wants to merge 2 commits intomainfrom
1p_tracking_list_filter_fix_env_query
Open

1p tracking list filter fix env query#711
timere-nemo wants to merge 2 commits intomainfrom
1p_tracking_list_filter_fix_env_query

Conversation

@timere-nemo
Copy link
Copy Markdown
Contributor

Title (Please follow the convention below)

[Buganizer ID: 502893537] Fix: Resolve Multi-Environment Search in Custom Lists


Description

Fixes a bug where searching for custom lists failed for items mapped to multiple environments or the wildcard "[\"*\"]" environment. The previous logic used a restrictive strict equality (eq) check on the environments field (stored as a JSON array string), which caused false negatives when searching for multi-environment items.


Checklist:

Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.

General Checks:

  • I have read and followed the project's contributing.md guide.
  • My code follows the project's coding style guidelines.
  • I have performed a self-review of my own code.
  • My changes do not introduce any new warnings.
  • My changes pass all existing tests.
  • I have added new tests where appropriate to cover my changes. (If applicable)
  • I have updated the documentation where necessary (e.g., README, API docs). (If applicable)

Open-Source Specific Checks:

  • My changes do not introduce any Personally Identifiable Information (PII) or sensitive customer data.
  • My changes do not expose any internal-only code examples, configurations, or URLs.
  • All code examples, comments, and messages are generic and suitable for a public repository.
  • I understand that any internal context or sensitive details related to this work are handled separately in internal systems (Buganizer for Google team members).

For Google Team Members and Reviewers Only:

  • I have included the Buganizer ID in the PR title or description (e.g., "Internal Buganizer ID: 123456789" or "Related Buganizer: go/buganizer/123456789").
  • I have ensured that all internal discussions and PII related to this work remain in Buganizer.
  • I have tagged the PR with one or more labels that reflect the pull request purpose.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the custom list search functionality that prevented items associated with multiple environments or a wildcard environment from being correctly retrieved. The fix involves refining the OData query used for environment filtering, transitioning from a strict equality comparison to a more flexible approach that accurately handles both specific environment matches and wildcard scenarios. This ensures that custom list searches return comprehensive and correct results, improving the reliability of the platform's data retrieval capabilities.

Highlights

  • Bug Fix: Custom List Environment Filtering: Resolved an issue where searching for custom lists failed for items mapped to multiple environments or the wildcard '["*"]' environment due to a restrictive strict equality check.
  • Improved OData Query Logic: Updated the OData query for environment filtering to use a combination of 'eq' for the wildcard '["*"]' and 'contains' for specific environments, ensuring accurate search results.
  • Package Version Updates: Bumped the versions of the 'integration-testing' and 'TIPCommon' packages to '2.3.7' across relevant configuration and lock files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tipcommon and integration-testing packages to version 2.3.7. The changes include an improvement to the environment filtering logic in the one_platform_soar_api.py client to support wildcard and specific environment matches. Feedback indicates that the new tipcommon wheel file is missing from the repository and the release_notes.yaml file needs to be updated to reflect the version bump, both of which are required by the style guide.

Comment thread packages/integration_testing/pyproject.toml
Comment thread packages/tipcommon/TIPCommon/pyproject.toml
@timere-nemo timere-nemo marked this pull request as ready for review April 22, 2026 19:13
@timere-nemo timere-nemo requested a review from a team as a code owner April 22, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant