Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #338 +/- ##
==========================================
+ Coverage 89.96% 90.00% +0.04%
==========================================
Files 104 104
Lines 9723 9723
Branches 529 529
==========================================
+ Hits 8747 8751 +4
+ Misses 447 445 -2
+ Partials 529 527 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
niyarin
approved these changes
Mar 25, 2025
Contributor
niyarin
left a comment
There was a problem hiding this comment.
Thank you for the fix.
I confirmed that the issue with the linter warning in test/cljam/io/gff_test.clj has been resolved.
Member
Author
|
@niyarin Thank you for reviewing! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes coding styles of test codes and does not introduce any changes of its behavior.
clj-kondoreportstest/cljam/io/gff_test.clj:319:70: error: Unresolved symbol: ?stron the master branch.I've removed the type hints in 909e6d2 because adding type hints to the symbols in
exprofclojure.test/arehas no effects on suppressing reflections.In f13581a, I've also fixed some coding styles warned by
kibit.Details
The strange behavior of the
:unresolved-symbolerror is due to differences in how metadata is handled.clojure.test/areusesclojure.template/do-templatewhich replaces symbols usingclojure.walk/postwalk-replace.Since a symbol’s metadata does not affect its identity during replacement, this process works as expected.
However,
clj-kondoemulatesclojure.template/do-templatewithclojure.walk/postwalk-replace, but it operates on AST nodes, which have:metafields directly attached.This difference causes replacement failure.
As seen above, since
clojure.test/arereplaces symbols in itsexpr, we need type information onargsrather than on the symbols inexpr.In the case of this PR, adding type hints is unnecessary because
argsare already typed vars.