Update route handling to use splat syntax#2
Open
raveeshbhalla wants to merge 1 commit intochrysb:mainfrom
Open
Update route handling to use splat syntax#2raveeshbhalla wants to merge 1 commit intochrysb:mainfrom
raveeshbhalla wants to merge 1 commit intochrysb:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes proxy route patterns from
"/path/*"to"/path/*splat"(and similarly for/openclaw,/assets,/hooks,/webhook,/api).On newer routing stacks that use path-to-regexp (e.g., Express 5 / the standalone router package), a bare * wildcard is no longer a valid token and throws at route registration time:
Naming the wildcard (*splat) preserves the intended “match everything under this prefix” behavior while providing a parameter name for the matcher. This prevents the server from crash-looping on startup in deployments that resolve to the newer path-to-regexp parser (I hit this on Railway with Node 22).
No behavior change intended beyond restoring compatibility; handlers continue to rewrite req.url as before and do not rely on the captured splat.