Skip to content

fix(Fletching): match "Logs" item name when using LOG material #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chsami merged 1 commit into from
Apr 16, 2026
Merged

fix(Fletching): match "Logs" item name when using LOG material #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/net/runelite/client/plugins/microbot/fletching/FletchingPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
@Slf4j
public class FletchingPlugin extends Plugin {

public static final String version = "1.6.3";
public static final String version = "1.6.4";

@Inject
private FletchingConfig config;
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/net/runelite/client/plugins/microbot/fletching/FletchingScript.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void run(FletchingConfig config) {
primaryItemToFletch = fletchingMode.getItemName();

if (fletchingMode == FletchingMode.PROGRESSIVE) {
secondaryItemToFletch = (model.getFletchingMaterial().getName() + " logs").trim();
secondaryItemToFletch = model.getFletchingMaterial().getLogItemName();
hasRequirementsToFletch = Rs2Inventory.hasItem(primaryItemToFletch)
&& Rs2Inventory.hasItemAmount(secondaryItemToFletch, model.getFletchingItem().getAmountRequired());
hasRequirementsToBank = !Rs2Inventory.hasItem(primaryItemToFletch)
Expand All @@ -84,7 +84,7 @@ public void run(FletchingConfig config) {
} else {
secondaryItemToFletch = fletchingMode == FletchingMode.STRUNG
? config.fletchingMaterial().getName() + " " + config.fletchingItem().getContainsInventoryName() + " (u)"
: (config.fletchingMaterial().getName() + " logs").trim();
: config.fletchingMaterial().getLogItemName();
hasRequirementsToFletch = Rs2Inventory.hasItem(primaryItemToFletch)
&& Rs2Inventory.hasItemAmount(secondaryItemToFletch, config.fletchingItem().getAmountRequired());
hasRequirementsToBank = !Rs2Inventory.hasItem(primaryItemToFletch)
Expand Down Expand Up @@ -115,7 +115,7 @@ private void bankItems(FletchingConfig config) {
case PROGRESSIVE:
Rs2Bank.depositAll(model.getFletchingItem().getContainsInventoryName());
calculateItemToFletch();
secondaryItemToFletch = (model.getFletchingMaterial().getName() + " logs").trim();
secondaryItemToFletch = model.getFletchingMaterial().getLogItemName();
break;
case PROGRESSIVE_STRUNG:
Rs2Bank.depositAll();
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/net/runelite/client/plugins/microbot/fletching/enums/FletchingMaterial.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ public enum FletchingMaterial

private final String name;

public String getLogItemName() {
return this == LOG ? "Logs" : name + " logs";
}

@Override
public String toString()
Expand Down
Loading