fix(ValeTotem): correct bow selection and withdraw race (#400)#402
Merged
fix(ValeTotem): correct bow selection and withdraw race (#400)#402
Conversation
- Select the configured bow option by name via Rs2Widget.handleProcessingInterface so the hotkey is resolved from the live fletching interface rather than a hardcoded child ID. The previous scheme mapped SHORTBOW → child 15 with hotkey-index 1, but widget 270,13's sparse dynamic children could produce "3" at that slot for some log types, causing shortbow selection to press the longbow key. - Bank withdraws now sleepUntil on the concrete predicate (hasKnife, hasLogBasket, log count reaches requested target) instead of the generic waitForInventoryChanges + re-check. Rs2Bank.withdrawOne/withdrawX return immediately after queueing the menu click, so under server lag the follow-up check would read stale state and spuriously report "no knife available" right after the knife was withdrawn. Bumps plugin to 1.0.10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps plugin to 1.0.10.