Skip to content

fix(questhelper): auto-accept quest-start prompts and pause re-interaction after dialogue#1749

Merged
chsami merged 2 commits intochsami:developmentfrom
runsonmypc:fix/questhelper-dialogue
Apr 18, 2026
Merged

fix(questhelper): auto-accept quest-start prompts and pause re-interaction after dialogue#1749
chsami merged 2 commits intochsami:developmentfrom
runsonmypc:fix/questhelper-dialogue

Conversation

@runsonmypc
Copy link
Copy Markdown
Contributor

Summary

  • Add Rs2Dialogue.acceptQuestStartDialogue() to detect "Would you like to start the <X> quest?" prompts (which QuestHelper doesn't pre-highlight) and click "Yes", so the script no longer cancels the dialogue by walking away.
  • Add a 4–7s cooldown in QuestScript after a tracked dialogue ends before re-clicking the NPC, so scripted animations/cutscenes between dialogue exchanges aren't interrupted into a retry loop.

Test plan

  • Start a quest with a "Would you like to start…" prompt (e.g. Witch's House, Vampire Slayer) with QuestHelper selected — plugin should auto-click Yes.
  • Run a quest with an existing [N]-highlighted choice path — confirm the prior behavior still works (no regression in handleQuestOptionDialogueSelection).
  • Observe a quest with a post-dialogue animation/cutscene — confirm the plugin waits rather than re-clicking immediately.

…ction after dialogue

- Add Rs2Dialogue.acceptQuestStartDialogue() to click "Yes" on
  "Would you like to start the <X> quest?" prompts that QuestHelper
  doesn't pre-highlight, so the script no longer cancels the dialogue
  by walking away.
- Add a 4-7s cooldown after a tracked dialogue ends before QuestScript
  re-clicks the NPC, to avoid interrupting scripted NPC animations or
  cutscenes that play out between dialogue exchanges.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 17, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ff1fecf4-25e5-485f-af23-e95fca579e85

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

These changes add dialogue cooldown handling to quest progression and a utility method for accepting quest start dialogues. A new dialogueCooldownEndsAt field tracks when a dialogue cooldown expires; when dialogue ends, the cooldown is set to a random 4–7 second duration, blocking further progression until it expires. Additionally, a new acceptQuestStartDialogue() method in the dialogue utility class detects quest start dialogue prompts (matching case-insensitive patterns starting with "would you like to start", containing "quest", and ending with "?") and automatically clicks the "Yes" option when conditions are met.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main changes: auto-accepting quest-start prompts and adding a cooldown after dialogue.
Description check ✅ Passed The description is directly related to the changeset, explaining both the new Rs2Dialogue method and the QuestScript cooldown with concrete test scenarios.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit 946464c into chsami:development Apr 18, 2026
2 checks passed
@runsonmypc runsonmypc deleted the fix/questhelper-dialogue branch April 19, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants