Skip to content

add ggplot and tidyverse other code improvements#1

Open
byandell wants to merge 154 commits intochurchill-lab:masterfrom
byandell-sysgen:master
Open

add ggplot and tidyverse other code improvements#1
byandell wants to merge 154 commits intochurchill-lab:masterfrom
byandell-sysgen:master

Conversation

@byandell
Copy link

@byandell byandell commented Apr 6, 2018

Dan,
I have pulled your recent commits to intermediate, and have two extra commits of my own. You can the mediation_scan and ggplot_mediation_scan in particular, and some changes to other routines to make them more general. I will be adding my mediation_test and mediation_triad in coming weeks.
Brian

@byandell
Copy link
Author

byandell commented Apr 8, 2018

I made some more additions to add mediation_test and mediation_triad. I have improvements I want to make on mediation_triad, to use model fit, but it is a decent first attempt. Note that the Tmem68 example that was in library has the target (Tmem68) among the mediators, so one must be careful.

@byandell
Copy link
Author

byandell commented Apr 9, 2018

Dan,
Your change in mediation.scan (and elsewhere) from POS to MIDDLE_POINT broke the example for mediation.scan. It would be better to leave as POS for generality and change your code something like the following:
med <- intermediate::mediation.scan(
target = pheno_clin[,pname,drop=FALSE],
mediator = expr_med,
annotation = annot.mrna.chr11 %>% rename(pos = "middle_point"),
covar = covar,
qtl.geno = ap,
method = "double-lod-diff")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants