Exercício Back-End Chuva Inc. JUL 2021#9
Open
Mathsphysis wants to merge 27 commits intochuva-inc:masterfrom
Open
Exercício Back-End Chuva Inc. JUL 2021#9Mathsphysis wants to merge 27 commits intochuva-inc:masterfrom
Mathsphysis wants to merge 27 commits intochuva-inc:masterfrom
Conversation
Changed condition to test the input string, changed the naming to better reflect meaning of \$charsLeft variable and added test to increase coverage of code.
Changed the test to provide the correct values and do the correct test
Author
|
Existe um bug no sistema, PR ainda não pronto para review |
Author
|
Encontrado um bug para quebra de palavras em que ainda caberiam na posição do vetor. Pull request ainda não pronto. |
All business logic now correctly implemented.
Created new function to perform the core business logic and clean up the entrypoint
Added a new function to wrap words in order to increase code legibility
Readability has been improved. Bigger overhead through function calls, but cyclomatic complexity of functions decreased and overall code quality increased.
Author
|
Exercício Concluído. |
refactor: Changed tests names for better code readability
feat: Added logic for negative length input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ainda existem verificações a fazer.