Skip to content

com.facebook.react.uimanager.events.Event.java changed after RN32. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heartjigi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

com.facebook.react.uimanager.events.Event.java changed after RN32. #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ android {

dependencies {
compile 'com.android.support:appcompat-v7:23.0.0'
compile 'com.facebook.react:react-native:0.19.+'
compile 'com.facebook.react:react-native:0.32.+'
}
1 change: 0 additions & 1 deletion android/src/main/java/com/chymtt/reactnativedropdown/Dropdown.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ public void onItemSelected(AdapterView<?> parent, View view, int pos, long id) {
.getEventDispatcher().dispatchEvent(
new DropdownEvent(
getId(),
SystemClock.uptimeMillis(),
pos,
parent.getSelectedItem().toString()));
}
Expand Down
4 changes: 2 additions & 2 deletions android/src/main/java/com/chymtt/reactnativedropdown/DropdownEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ public class DropdownEvent extends Event<DropdownEvent> {
private final int mPosition;
private final String mValue;

public DropdownEvent(int viewId, long timestampMs, int position, String value) {
super(viewId, timestampMs);
public DropdownEvent(int viewId, int position, String value) {
super(viewId);
mPosition = position;
mValue = value;
}
Expand Down