Skip to content

Add date time skeletons availability (like for number skeletons)#20

Open
mashiachy wants to merge 1 commit intocibernox:masterfrom
mashiachy:master
Open

Add date time skeletons availability (like for number skeletons)#20
mashiachy wants to merge 1 commit intocibernox:masterfrom
mashiachy:master

Conversation

@mashiachy
Copy link
Copy Markdown

Added date time skeletons availability (like for number skeletons).
Added boolean literals for number skeleton (was broken this syntax: {year, number, ::group-off})

@cibernox
Copy link
Copy Markdown
Owner

cibernox commented Nov 14, 2022

Can you add tests for this? It should be simple, we just need example fixtures with inputs and outputs added in in https://github.com/cibernox/babel-plugin-precompile-intl/blob/master/test/fixtures/default

You can either create a new file or add them to one of the existing files. There's already several examples of number skeletons implemented and tested in https://github.com/cibernox/babel-plugin-precompile-intl/blob/master/test/fixtures/default/format-numbers/input.js , but the features of number skeletons are so varied that I implemented first the ones I needed and I thought most people would need too.

@cibernox
Copy link
Copy Markdown
Owner

Also, when writing tests, try to be mean and look for edge cases, combining number skeletons where possible, put them at the beginning of a sentence, at the end, in the middle...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants