Stricter null checking to not filter out empty strings#42
Open
vekunz wants to merge 1 commit intocibernox:masterfrom
Open
Stricter null checking to not filter out empty strings#42vekunz wants to merge 1 commit intocibernox:masterfrom
vekunz wants to merge 1 commit intocibernox:masterfrom
Conversation
Contributor
Author
|
Hi, is there a chance that this gets merged or don't you want this behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have the problem that precopile-intl-runtime prints a warning to console that a message was not found in the language files, even if the message is present but is only an empty string. I found two places in the code of precompile-int-runtime that implicitly filters out empty strings. I have made these two places more strict so that empty strings won't be filtered out.