Conversation
This comment was marked as resolved.
This comment was marked as resolved.
79aa885 to
0d1c471
Compare
|
🤖 Autorebase failed The automatic rebase of this PR failed. This could be due to:
Please manually rebase your branch or resolve any conflicts: git checkout your-branch-name
git rebase main
# Resolve any conflicts if they occur
git push --force-with-leaseThe autorebase will be attempted again on the next scheduled run. |
for now, we either have SSR'd pages but no reactivity (handmade plugin) OR no SSR but reactivity (bun's official plugin) thing is i would want to directly server-render from the DB, not have to make a XHR roundtrip via API which would be dumb another alterntive is a full sveltekit project, there's some interesting work. main hurdle is sharing the drizzle schema, since we're using bun:sqlite as the driver. Using better-sqlite3 and node adapter for sveltekit results in loss of type info because the schema is not type-compatible between DB drivers, but I saw a (unofficial) bun adapter for sveltekit, so maybe we can use bun:sqlite on the svelte kit server side anyways. im excited to try out sveltekit remote functions so maybe ill go with that but a standalone, Bun.served'd dashboard would be kinda neat (and lightweight), and I might have the opportunity to contribute to oven-sh/bun directly which would be nice, so idk. i feel like ssr for the official plugin is achievalbe (and its certainly not a roadmap prority for the bun team)
0d1c471 to
b000283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for now, we either have SSR'd pages but no reactivity (handmade plugin) OR no SSR but reactivity (bun's official plugin)
thing is i would want to directly server-render from the DB, not have to make a XHR roundtrip via API which would be dumb
another alterntive is a full sveltekit project, there's some interesting work. main hurdle is sharing the drizzle schema, since we're using bun:sqlite as the driver. Using better-sqlite3 and node adapter for sveltekit results in loss of type info because the schema is not type-compatible between DB drivers, but I saw a (unofficial) bun adapter for sveltekit, so maybe we can use bun:sqlite on the svelte kit server side anyways. im excited to try out sveltekit remote functions so maybe ill go with that
but a standalone, Bun.served'd dashboard would be kinda neat (and lightweight), and I might have the opportunity to contribute to oven-sh/bun directly which would be nice, so idk. i feel like ssr for the official plugin is achievalbe (and its certainly not a roadmap prority for the bun team)
other possibility: sveltekit app with adapter-node, and import the built handler to use it on a custom server, see https://svelte.dev/docs/kit/adapter-node#Custom-server