✅ Replace E2E DB dumps with Playwright storage states#1115
Draft
✅ Replace E2E DB dumps with Playwright storage states#1115
Conversation
Member
Author
|
Blocked on microsoft/playwright#38915 |
390a4ba to
a555bc3
Compare
Contributor
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller |
Member
Author
|
will try this patch tmrw diff --git a/node_modules/playwright-core/lib/utils/isomorphic/utilityScriptSerializer.js b/node_modules/playwright-core/lib/utils/isomorphic/utilityScriptSerializer.js
index 8252f2d..577b709 100644
--- a/node_modules/playwright-core/lib/utils/isomorphic/utilityScriptSerializer.js
+++ b/node_modules/playwright-core/lib/utils/isomorphic/utilityScriptSerializer.js
@@ -141,6 +141,11 @@ function parseEvaluationResultValue(value, handles = [], refs = /* @__PURE__ */
return handles[value.h];
if ("ta" in value)
return base64ToTypedArray(value.ta.b, typedArrayConstructors[value.ta.k]);
+ if ("ab" in value)
+ {
+ const array = base64ToTypedArray(value.ab.b, Uint8Array);
+ return array.buffer;
+ }
}
return value;
}
@@ -206,6 +211,9 @@ ${value.stack}`;
if (isTypedArray(value, ctor))
return { ta: { b: typedArrayToBase64(value), k } };
}
+ if (isTypedArray(value, ArrayBuffer)) {
+ return { ab: {b: typedArrayToBase64(value) } };
+ }
const id = visitorInfo.visited.get(value);
if (id)
return { ref: id }; |
a555bc3 to
334544c
Compare
953cfee to
e669cfa
Compare
Regenerate-Protocol: No
e669cfa to
c4c8041
Compare
daa450c to
ca2d644
Compare
Contributor
|
✅ Coverage is up by 0.02% (from 49.95% to 49.97%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1114