Skip to content

Add default values on metadata definitions#1236

Merged
gwennlbh merged 6 commits intomainfrom
metadata-defaults
Feb 14, 2026
Merged

Add default values on metadata definitions#1236
gwennlbh merged 6 commits intomainfrom
metadata-defaults

Conversation

@gwennlbh
Copy link
Member

@gwennlbh gwennlbh commented Feb 13, 2026

Fixes #1223
Fixes #1224

@gwennlbh gwennlbh force-pushed the protocol-no-toplevel-crop-field branch from 7c15cd4 to a16f40a Compare February 13, 2026 13:56
@gwennlbh gwennlbh force-pushed the protocol-no-toplevel-crop-field branch 3 times, most recently from f56c75b to d538b1f Compare February 13, 2026 14:42
@gwennlbh gwennlbh changed the base branch from protocol-no-toplevel-crop-field to main February 13, 2026 19:07
@gwennlbh gwennlbh force-pushed the metadata-defaults branch 3 times, most recently from 7ce562c to 5c30e69 Compare February 13, 2026 23:36
@gwennlbh gwennlbh temporarily deployed to #1236: App preview February 13, 2026 23:39 — with GitHub Actions Inactive
@gwennlbh gwennlbh temporarily deployed to #1236: App preview February 14, 2026 13:54 — with GitHub Actions Inactive
@gwennlbh gwennlbh temporarily deployed to #1236: App preview February 14, 2026 14:39 — with GitHub Actions Inactive
@gwennlbh gwennlbh temporarily deployed to #1236: App preview February 14, 2026 16:18 — with GitHub Actions Inactive
@gwennlbh gwennlbh temporarily deployed to #1236: App preview February 14, 2026 16:22 — with GitHub Actions Inactive
@gwennlbh
♻️ Use ex() instead of expect.soft() in E2E tests
bc0793f 
Encourages using expect.soft() (which is better)
@gwennlbh
♻️ Rename non-soft expect() to assert()
90d9c63 
To emphasize that it stops the test on fail
@gwennlbh
♻️ Rename ex() to expect()
951a00e 
Since now it's clear that non-soft expect() is assert() instead
@gwennlbh
💡 Explain soft-by-default expect() rationale in tests/fixtures.ts
87ba44e
@gwennlbh gwennlbh temporarily deployed to #1236: App preview February 14, 2026 16:46 — with GitHub Actions Inactive
@gwennlbh gwennlbh temporarily deployed to #1236: App preview February 14, 2026 17:00 — with GitHub Actions Inactive
@gwennlbh gwennlbh temporarily deployed to #1236: Unit tests February 14, 2026 17:01 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2026 •
edited
Loading

✅ Coverage is up by 0.69% (from 49.52% to 50.21%)

@gwennlbh gwennlbh temporarily deployed to #1236: Bundle breakdown February 14, 2026 17:06 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2026 •
edited
Loading

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
229 46.64 MB → 46.65 MB (+11.57 kB)
11.54 MB → 11.54 MB (gzip)		 +0.02%
Changeset
File Δ Size
InputSelectProtocol.svelte 🆕 +1.85 kB 0 B → 1.85 kB
metadata/defaults.ts 🆕 +985 B 0 B → 985 B
decorators/inline.js 🆕 +368 B 0 B → 368 B
_app/immutable/nodes/0.DDH-IvBC.js 🆕 +105 B 0 B → 105 B
minutesToMilliseconds.js 📈 +296 B (+389.47%) 76 B → 372 B
common.js 📈 +3.41 kB (+175.21%) 1.95 kB → 5.36 kB
metadata.js 📈 +2.82 kB (+38.82%) 7.26 kB → 10.08 kB
+page.js 📈 +126 B (+12.50%) 1008 B → 1.11 kB
storage.ts 📈 +70 B (+2.34%) 2.92 kB → 2.99 kB
results.js 📉 -1.08 kB (-45.99%) 2.34 kB → 1.26 kB
i18n.js 📉 -296 B (-77.08%) 384 B → 88 B
lib/InputSelectProtocol.svelte 🔥 -1.85 kB (-100%) 1.85 kB → 0 B
format/longFormatters.js 🔥 -755 B (-100%) 755 B → 0 B
_app/immutable/nodes/0.BS28daKH.js 🔥 -105 B (-100%) 105 B → 0 B
View detailed bundle breakdown

Added

Asset File Size % Changed
_app/immutable/chunks/qJss9Dzf.js 0 B → 352.94 kB (+352.94 kB)
0 B → 149.83 kB (gzip)		 -
_app/immutable/nodes/31.BU857moH.js 0 B → 8.17 kB (+8.17 kB)
0 B → 3.91 kB (gzip)		 -
_app/immutable/chunks/2olO8r_B.js 0 B → 6 kB (+6 kB)
0 B → 2.48 kB (gzip)		 -
_app/immutable/nodes/0.DDH-IvBC.js 0 B → 105 B (+105 B)
0 B → 120 B (gzip)		 -

Removed

Asset File Size % Changed
_app/immutable/chunks/B7XGM72D.js 338.65 kB → 0 B (-338.65 kB)
145.33 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/Dzk8Wqvv.js 15.16 kB → 0 B (-15.16 kB)
5.41 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/31.C3-wzjkn.js 7.05 kB → 0 B (-7.05 kB)
3.32 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/0.BS28daKH.js 105 B → 0 B (-105 B)
120 B → 0 B (gzip)		 -100%

Bigger

Asset File Size % Changed
_app/immutable/workers/start-[hash].js 1.71 MB → 1.71 MB (+5.33 kB)
584.83 kB → 586.31 kB (gzip)		 +0.30%

Smaller

No assets were smaller

@gwennlbh gwennlbh marked this pull request as ready for review February 14, 2026 17:32
@gwennlbh gwennlbh enabled auto-merge February 14, 2026 17:32
@gwennlbh gwennlbh disabled auto-merge February 14, 2026 20:34
@gwennlbh gwennlbh merged commit 8f06c90 into main Feb 14, 2026
220 of 232 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add dynamic default values on metadata definitions Add default values on session metadata definitions

1 participant

@gwennlbh