Fix all blocks and samples on linux, add cairo support#2134
Closed
ppff wants to merge 15 commits intocinder:masterfrom
Closed
Fix all blocks and samples on linux, add cairo support#2134ppff wants to merge 15 commits intocinder:masterfrom
ppff wants to merge 15 commits intocinder:masterfrom
Conversation
added 15 commits
January 11, 2020 02:45
ppff
commented
Feb 13, 2020
ppff
commented
Feb 13, 2020
ppff
commented
Feb 13, 2020
ppff
commented
Feb 13, 2020
ppff
commented
Feb 13, 2020
Collaborator
|
Really awesome that you took this on, thanks! It will be great to finally have all samples building in Linux, a big step in cross-platform equality. We're gearing up for a release within the very near future, so I think we'll try to get this work integrated within the next release cycle. I think we should probably simplify this PR to things related to cairo / svg samples as much as possible. I haven't yet had time to review or run this code, but I hope that we can soon. |
This was referenced Feb 14, 2020
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to try Cinder for an upcoming project. I'm a full time linux user, and couldn't help but notice that most samples wouldn't build on Ubuntu 18.04.
Hence, I reviewed each block and each sample to make sure they now build and work (except those that aren't supported on linux of course). I added the samples that aren't supported to the
CINDER_SKIP_SAMPLESlist.This also led me to add linux support for Cairo because I wanted to try the
_svgsamples. I've changed a few bits of code in the Cairo block, one should try to build it on windows and osx to make sure I didn't break anything. If you want a second PR just for that, I can rework my branch.This PR should close #1483 close #2052 close #2022 and maybe close #1815 (most Cairo samples also require
Renderer2Dwhich is still not implemented on linux).Any comments would be appreciated.