Add sqr function to CinderMath.h#2175
Open
IntellectualKitty wants to merge 1 commit intocinder:masterfrom
Open
Add sqr function to CinderMath.h#2175IntellectualKitty wants to merge 1 commit intocinder:masterfrom
IntellectualKitty wants to merge 1 commit intocinder:masterfrom
Conversation
Collaborator
|
What's the use case for this? |
Author
|
Using a squaring function makes for shorter, easier code. It also more closely resembles the mathematical equation the code is performing. For example, this seems shorter, simpler, and easier to read: than this: |
Collaborator
|
I am up for this change if there are no objections |
Contributor
|
Just a minor point: what about calling it |
Collaborator
|
As a side note: can be simplified to: or: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.