added getters to each geom::Object based off of available setters [Take Two]#2293
Open
morphogencc wants to merge 2 commits intocinder:masterfrom
Open
added getters to each geom::Object based off of available setters [Take Two]#2293morphogencc wants to merge 2 commits intocinder:masterfrom
morphogencc wants to merge 2 commits intocinder:masterfrom
Conversation
Collaborator
|
Hi @morphogencc, you'll also want to turn off the auto-format settings in your IDE so you aren't creating all the whitespace changes in there. Usually if you want to get your changes into an open source library, the best approach is to create a PR with the minimal set of changes possible. In this case I believe that would be just the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt at resolving #1176! I created getters for each geom::Object type based only on what setters were available.