Fixes missing German folder. Fixes ASI Loader path support. Adds CI build test, & a release workflow which fixes compability with other ASI loader mods#17
Open
ShizCalev wants to merge 4 commits intocipherxof:mainfrom
Conversation
Owner
|
I think it might be better to offload the assets somewhere that the CI can download and package. I don't really know if I want to muddy git with a bunch of binary files that can't be diffed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added PR CI tests (build log for this commit is here)
Added a manually triggered release workflow that builds the solution & packages the latest release version of ASI loader with the same naming convention as MGSHDFix to fix ASI Loader double initialization crashes (Fixes Compatible with MGSHD Fix? #16, Fixes How Can I use this mod with DXVK ? :/ "Game won't launch" #10, Fixes Compatibility with reshade #9)
(Example of the final zip from testing the release workflow w/ my fork)

Added the missing German folder - Fixes Can't move while weapon ist equipped #8, Fixes Forgot german? #4, Fixes Can not move with equipped weapon (german folder missing) #13
Fixes ASI loader path support so the mod can be loaded properly from the /plugins subdirectory
Updated minhook & minini (the old version of minhook had a minor memory leak that was since resolved.)
Added a visible error message if the config file isn't present instead of silently failing.
Adds installation instructions to the readme (Fixes Where do i place the files? #12)
#15 is ready to be merged too btw. :>