test: add Python unit tests and CI workflow#27
Open
dolepee wants to merge 1 commit intocirclefin:masterfrom
Open
test: add Python unit tests and CI workflow#27dolepee wants to merge 1 commit intocirclefin:masterfrom
dolepee wants to merge 1 commit intocirclefin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 30 unit tests for the Python codebase and a GitHub Actions CI workflow to run them automatically.
Problem
The repository has zero Python test coverage. The existing CI workflow only runs Foundry/Forge tests for the Solidity contracts, leaving the Python code (
chainmail.py,chainlink.py) entirely untested.Changes
Test files:
tests/test_chainmail.py— 15 tests covering:get_content_string(): valid roundtrip, unicode, empty input, invalid base64/zlib error handlingget_verification_url(): URL format, parameter encoding, roundtrip withget_content_string()modify_signature_header(): replacement, no-match passthroughPGP_sign_message()andverify_signature(): GPG calls (mocked)send_email(): end-to-end integration with mocked GPGemail_send_message(): stub behaviortests/test_chainlink.py— 15 tests covering:hash(),hash_email_address(),hash_message(): determinism, case-insensitivity, whitespace normalizationparse_cast_send_output(): success/failure parsing ofcast sendoutputis_cast_and_send_succeed(): boolean result verificationget_chainmail_address(): missing file and existing file scenariosCI workflow:
.github/workflows/python-tests.yml— runspytest tests/ -von push/PR to master across Python 3.10, 3.11, and 3.12Dependencies:
pytestandpytest-mocktorequirements.txtDesign decisions