fix: Remove unexpected large top spacing in modal presentation (#33)#35
Open
addnad wants to merge 1 commit intocirclefin:masterfrom
Open
fix: Remove unexpected large top spacing in modal presentation (#33)#35addnad wants to merge 1 commit intocirclefin:masterfrom
addnad wants to merge 1 commit intocirclefin:masterfrom
Conversation
…efin#33) On iOS, even with modalPresentationStyle = .overFullScreen, the presented view controller's content was respecting safe area insets, causing a large blank area above the modal content (particularly visible with notches/status bars). The fix: - Set the view controller's frame to UIScreen.main.bounds to ensure full screen coverage - Use additionalSafeAreaInsets with negative top value to offset the safe area, allowing the modal content to extend behind the status bar - Added iOS 11.0+ availability check for the additionalSafeAreaInsets property This applies to both RnWalletSdk.swift and ProgrammablewalletRnSdkModule.swift to cover both Bare React Native and Expo use cases. Fixes: circlefin#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS, even with modalPresentationStyle = .overFullScreen, the presented view controller's content was respecting safe area insets, causing a large blank area above the modal content (particularly visible with notches/status bars).
The fix:
This applies to both RnWalletSdk.swift and ProgrammablewalletRnSdkModule.swift to cover both Bare React Native and Expo use cases.
Fixes: #33