Factor out common install scripts; bump Verilator in integration-test #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
force-pushed
the
fschuiki/bump-verilator
branch
3 times, most recently
from
faf293b to
68c2b76
Compare
Move the commonly-used tool installation scripts into a new `install/` directory instead of each image having an almost-identical copy of it lying around. Move the dockerfiles into the same directory such that they are built from the same context, having access ot the same install script directory. This also bumps Verilator in the integration-test image to 5.040, which was the original trigger for this. Also move cleanup into the individual install scripts instead of having the dockerfiles run rm.
fabianschuiki
force-pushed
the
fschuiki/bump-verilator
branch
from
68c2b76 to
7c88c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the commonly-used tool installation scripts into a new
install/directory instead of each image having an almost-identical copy of it lying around.This also bumps Verilator in the integration-test image to 5.040, which was the original trigger for this.
Also move cleanup into the individual install scripts instead of having the dockerfiles run rm.