Skip to content

Replace deprecated and vulnerable package #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kass-kass wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Replace deprecated and vulnerable package #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bb1a27
Add valibot json schema package
kass-kass Dec 8, 2025
7d5e8b8
Remove deprecated package
kass-kass Dec 8, 2025
0383bfc
Run pnpm i
kass-kass Dec 8, 2025
0a9cd64
Attempt in-place replacement of package
kass-kass Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@
"optionalDependencies": {
"@exodus/schemasafe": "^1.3.0",
"@finom/zod-to-json-schema": "^3.24.11",
"@gcornut/valibot-json-schema": "^0.42.0",
"@typeschema/class-validator": "^0.3.0",
"@vinejs/vine": "^3.0.1",
"arktype": "^2.1.22",
Expand All @@ -185,6 +184,7 @@
"zod": "^4.1.11"
},
"dependencies": {
"@valibot/to-json-schema": "^1.4.0",
"devalue": "^5.3.2",
"memoize-weak": "^1.0.2",
"ts-deepmerge": "^7.0.3"
Expand Down
85 changes: 13 additions & 72 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 5 additions & 18 deletions src/lib/adapters/valibot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,29 +18,16 @@ import {
} from 'valibot';
import { memoize } from '$lib/memoize.js';
import {
type ToJSONSchemaOptions,
toJSONSchema as valibotToJSON
} from '@gcornut/valibot-json-schema';
toJsonSchema as valibotToJSON,
type ConversionConfig as ToJSONSchemaOptions
} from '@valibot/to-json-schema';
import type { JSONSchema } from '../jsonSchema/index.js';

type SupportedSchemas = GenericSchema | GenericSchemaAsync;

const defaultOptions = {
strictObjectTypes: true,
dateStrategy: 'integer' as const,
bigintStrategy: 'integer' as const,
ignoreUnknownValidation: true,
customSchemaConversion: {
custom: () => ({}),
instance: () => ({}),
file: () => ({}),
blob: () => ({})
}
} satisfies ToJSONSchemaOptions;

/* @__NO_SIDE_EFFECTS__ */
export const valibotToJSONSchema = (options: ToJSONSchemaOptions) => {
return valibotToJSON({ ...defaultOptions, ...options }) as JSONSchema;
export const valibotToJSONSchema = (options: ToJSONSchemaOptions & { schema: Parameters<typeof valibotToJSON>[0] }) => {
return valibotToJSON(options.schema, options) as JSONSchema;
};

async function _validate<T extends SupportedSchemas>(
Expand Down