fix(streaming/native): fix issue with empty referenceHash from stream… #2179
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blattersturm
suggested changes
Aug 27, 2023
code/components/citizen-resources-client/src/ResourceCacheDeviceV2.cpp
Outdated
Show resolved
Hide resolved
code/components/citizen-resources-client/src/ResourceCacheDeviceV2.cpp
Outdated
Show resolved
Hide resolved
PichotM
force-pushed
the
streaming-native2
branch
from
bdb6f3e to
b97634a
Compare
Contributor
Author
|
i removed that |
thorium-cfx
added
the
triage
|
up |
FabianTerhorst
requested review from
FabianTerhorst
and removed request for
martonp96
prikolium-cfx
added
manual-review
Contributor
|
I just tried using the native without knowing the underlying issue (based a system of ugc ytds on it), then i noticed this pr and i'm now hopeful i won't have to trash my code if it's merged. |
Contributor
Author
|
up |
Contributor
|
I am a person who has ideas that would be most practically served through a native like this. (namely, storing copious .yvr files in a blob store like S3) |
Collaborator
|
Thanks for the Pull Request and your interest in it, but as you know this native command is experimental and we don't want to extend this experiment now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing natives
Updated version for this PR: #1751 , which aim to fix
REGISTER_STREAMING_FILE_FROM_URL