fix(citizen-script-lua): Fix crash with nil value as name in CreateTh… #3077
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
niekschoemaker
force-pushed
the
fix-crash-create-thread-now
branch
from
ba5772d to
6c6a362
Compare
github-actions
bot
added
triage
niekschoemaker
force-pushed
the
fix-crash-create-thread-now
branch
from
7c39543 to
6c6a362
Compare
Contributor
Author
|
Tried to merge, but merge commits aren't allowed by title, so I undid those changes, that's the mess with forced pushes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix a crash that happens when a nil value is passed to Citizen.CreateThreadNow as the name.
How is this PR achieving the goal
It checks to see if lua_tostring returns a null pointer and if it does leaves the name empty.
This PR applies to the following area(s)
ScRT: LUA
Successfully tested on
Game builds: 12206
Platforms: Windows
Checklist
Fixes issues