feat(scrt/v8): add support for source maps #3742
Open
+3,458
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a non-minified version of https://github.com/7rulnik/source-map-js to handle loading source maps. This also changes behavior for the Node ScRT to go back to using the shared v8 unhandled promise rejection so we get proper source maps for these calls. This adjust the behavior of FORMAT_STACK_TRACE so we don't eat errors if they happen on the same tick for JS/C# at the cost that we get less information than we normaly would, but this should only really happen with export calls, in that case we only lose information from Lua ScRT's since JS/C# both will supply their current stack trace as arguments.
github-actions
bot
added
ScRT: JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a non-minified version of https://github.com/7rulnik/source-map-js to handle loading source maps.
This also changes behavior for the Node ScRT to go back to using the shared v8 unhandled promise rejection so we get proper source maps for these calls.
This adjust the behavior of FORMAT_STACK_TRACE so we don't eat errors if they happen on the same tick for JS/C# at the cost that we get less information than we normaly would, but this should only really happen with export calls, in that case we only lose information from Lua ScRT's since JS/C# both will supply their current stack trace as arguments.
This PR applies to the following area(s)
ScRT: JS
Successfully tested on
Game builds: ..
Platforms: Windows
Checklist
Fixes issues