Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 26 26
Lines 1831 1831
Branches 316 316
=======================================
Hits 1620 1620
Misses 183 183
Partials 28 28 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
whoabuddy
left a comment
There was a problem hiding this comment.
Overall looks good! 🙏 Left some feedback on what I saw in the review comments.
I would like to add some testing around the contract alongside the simulation, mostly to make sure the voting works as expected. Payout code looks clean/simple but will be important to make sure we can reproduce those numbers from the CCIP text/resources.
| (define-constant CCIP_016 { | ||
| name: "Refund Incorrect CCD007 Payouts", | ||
| link: "https://github.com/citycoins/governance/blob/feat/add-ccip-016/ccips/ccip-016/ccip-016-refund-incorrect-ccd007-payouts.md", | ||
| hash: "", |
There was a problem hiding this comment.
Noting that the CCIP-016 governance text needs to be updated and hash can be added here.
We're on version 3 for clarinet, probably failing check because of new epoch definition.
This PR