feat: CRS option for BBox and respect content negotiation #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new module for CRS transformations, enabling the conversion of bounding boxes between different coordinate systems, specifically from WGS84 to the Dutch RD New (EPSG:28992). Updated the collection_items handler to support bbox transformations based on the provided bbox-crs parameter, enhancing spatial query capabilities. Additionally, updated dependencies in Cargo.toml files to include the proj crate for projection functionalities and bumped the Python package version.
Enhanced the API to include CityJSON metadata in the response, incorporating versioning, transformation parameters (scale and translate), and extensions. This addition improves compatibility with CityJSON specifications and enriches the data provided to clients.
Introduced a new `fs_handler` module for handling local file access and updated the `http_handler` for remote file access. Enhanced the `AppState` structure to include a flag indicating whether the FCB URL is a local file. Updated the routing logic in the `create_app` function to direct requests to the appropriate handler based on the file type. This refactor improves the flexibility of the API in handling different data sources.
Refactored the `fs_handler` and `lib.rs` files to enhance code readability by applying consistent formatting to function calls and logging statements. This includes breaking long lines for better clarity and ensuring that logging messages are uniformly structured. Additionally, removed commented-out test code in `e2e.rs` to maintain a clean codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new module for CRS transformations, enabling the conversion of bounding boxes between different coordinate systems, specifically from WGS84 to the Dutch RD New (EPSG:28992). Updated the collection_items handler to support bbox transformations based on the provided bbox-crs parameter, enhancing spatial query capabilities. Additionally, updated dependencies in Cargo.toml files to include the proj crate for projection functionalities and bumped the Python package version.