Let admin choose default boot proto. Respect both CIVICRM_BOOT and CIVCRM_SETTINGS.#152
Merged
totten merged 3 commits intocivicrm:masterfrom Mar 10, 2023
Merged
Conversation
…ICRM_SETTINGS. This is preparation for v0.4. The ultimate aim is to flip the default boot behavior (`full/Bootstrap` <=> `cms-full/CmsBootstrap`); but this is a big change. This patch is about allowing admins fine-tune the transition. * In v0.3, the default is `full/Bootstrap`. * In v0.4, it will be `cms-full/CmsBootstrap`. * If you're on v0.3 and want to get ahead (*start using `CmsBootstrap` by default; now*), then you can explicitly set `CIVICRM_BOOT=Auto://` * If you're on v0.4 and want to stay behind (*stay on `Bootstrap` by default*), then you can explicitly set `CIVICRM_SETTING=Auto` These env-vars already exist, but they're not consistently respected. You sometimes need to manually set `--level=full` or `--level=cms-full`. This patch allows you switch without needing to manually pass `--level=X` with each call.
Member
Author
|
Test failures are unrelated/pre-existing. |
totten
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Extracted from #145.)
This is preparation for
v0.4.x. The ultimate aim is to flip the default boot behavior (full/Bootstrap.php<=>cms-full/CmsBootstrap.php); but that is a big change. This patch allows admins fine-tune the transitional period.full/Bootstrap.php.cms-full/CmsBootstrap.php.CmsBootstrap.phpby default; now), then you can explicitly setCIVICRM_BOOT=Auto://. This setting will be respected on either version.Bootstrap.phpby default), then you can explicitly setCIVICRM_SETTING=Auto. This setting will be respected on either version.These env-vars already exist, but they're not consistently respected. You sometimes need to manually set
--level=fullor--level=cms-full. This patch makes it easier to switch -- you can express a preference for either style, and you don't need to manually pass--level=Xwith each call.This PR also updates the README to describe the options.