This repository was archived by the owner on Nov 24, 2017. It is now read-only.
Fixes parsing of invalid UTF-8 characters#70
Open
ce-manalang wants to merge 1 commit intocjohansen:masterfrom
ce-manalang:fix_parsing_invalid_utf_8_chars
Open
Fixes parsing of invalid UTF-8 characters#70ce-manalang wants to merge 1 commit intocjohansen:masterfrom ce-manalang:fix_parsing_invalid_utf_8_chars
ce-manalang wants to merge 1 commit intocjohansen:masterfrom
ce-manalang:fix_parsing_invalid_utf_8_chars
Conversation
Owner
|
So this basically ignores invalid utf-8 characters? Wouldn't it be better to fix them in the source files? |
Author
|
@cjohansen yes we can fix the source files but if we want to juice a lot of js files with too many invalid chars, we have to go through them one by one. Is it a good compromise if we just add a warning while juicing a file with invalid chars that those chars will be ignored? That way, juicing problematic files won't error out but it will not just silently juice. Thoughts? |
Owner
|
Warnings are a good compromise :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followed advice from http://stackoverflow.com/a/8873922