feat: allow to disable silence filtering#774
Closed
AlexP11223 wants to merge 1 commit intocjpais:mainfrom
Closed
Conversation
Owner
|
Ill be adding this in #832 directly, so it will supersede this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
Human Written Description
I added the "Filter Silence" checkbox (default on) in the Advanced settings, so that it is possible to disable silence filtering.
The silence filtering was causing issues for me, at least when speaking quietly. Some parts of the audio were missing in the history, such as in the middle.
It seems that in my case Whisper (Large) itself handles silence quite well, I have seen some hallucination only in very short texts, like several words.
Testing
Screenshots/Videos (if applicable)
AI Assistance
If AI was used: