Refactor shard-id into a parameter to support new API semantics#6
Open
redbeardymcgee wants to merge 3 commits intocjsauer:masterfrom
Open
Refactor shard-id into a parameter to support new API semantics#6redbeardymcgee wants to merge 3 commits intocjsauer:masterfrom
redbeardymcgee wants to merge 3 commits intocjsauer:masterfrom
Conversation
`api-url` is currently modified to temporarily test without other intrusive changes to calling conventions. Issue cjsauer#2 describes what the main issue seems to be, but fixing this is out of scope of the current goal.
Platform and region are incompatible parameters now. API expects either a platform, or combined platform-region, as a shard route. Some endpoints expect a platform, others expect a platform-region.
Contributor
Author
|
I don't understand why the ranked stats support got smashed inside this pull request as well. I'd like to yoink those back out but I am obviously not git-fluent yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address the problem with #2. It does introduce a breaking change, but I consider this to be worthwhile until an official tagged and versioned release of this library is produced.
With a couple more changes and a full test suite, I think that could be achieved as well.