Fix write to freed memory after deleting the last board.#61
Merged
cknave merged 1 commit intocknave:mainfrom Nov 29, 2023
Merged
Fix write to freed memory after deleting the last board.#61cknave merged 1 commit intocknave:mainfrom
cknave merged 1 commit intocknave:mainfrom
Conversation
kristomu
changed the title
This doesn't seem to produce any immediate crashes in main, but valgrind reports an error, and it causes a more immediate crash in my bind-handling PR. The bug can be reproduced by creating a new world, then a new board, making it the current board, deleting it in the selector, and then selecting the title screen.
kristomu
force-pushed
the
board-commit-fix
branch
from
a02c955 to
82d398d
Compare
Owner
|
Thanks for the fix! I should have some time to look at #60 this weekend. |
kristomu
added a commit
to kristomu/kevedit
that referenced
this pull request
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't seem to produce any immediate crashes in main, but valgrind reports an error, and it causes a more immediate crash in my bind-handling PR.
The bug can be reproduced by creating a new world, then a new board, making it the current board, deleting it in the selector, and then selecting the title screen.