Permit CTRL+A #char-specific behavior anywhere, not just at line start.#65
Open
kristomu wants to merge 2 commits intocknave:mainfrom
Open
Permit CTRL+A #char-specific behavior anywhere, not just at line start.#65kristomu wants to merge 2 commits intocknave:mainfrom
kristomu wants to merge 2 commits intocknave:mainfrom
Conversation
…ent. For instance, first using CTRL+A to set the character number after a #char comand to 99, then using CTRL+A again to set it to 100 would leave the cursor at the last digit, which would cause it to be cut off if one were to press enter. This change always places it after the last digit so that pressing enter minimizes one's surprise.
Contributor
Author
|
I'm not sure what the camelcase/snake case convention is because textedit has both of them, so I just made a guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #62 and is also reasonably robust. E.g. editing a different part of a commented-out line that also contains #char won't trigger the #char behavior unless the cursor is in the right spot.