Skip to content

Conversation

@shel-ho
Copy link
Contributor

@shel-ho shel-ho commented Oct 15, 2025

Addresses #79 and evaluates LID

@shel-ho shel-ho linked an issue Oct 15, 2025 that may be closed by this pull request
@clams-bot clams-bot added this to infra Oct 15, 2025
@github-project-automation github-project-automation bot moved this to Todo in infra Oct 15, 2025
@keighrim
Copy link
Member

I understand @shel-ho is working on adding confusion matrix element to the report for this task. Can you work on "promoting" that feature to the common package? That'd be helpful to address #88 when we received the source assets.

@keighrim
Copy link
Member

I think we need to get rid of --task argument, and instead replace it with a more generic argument to tell which label "to care". For example, instead of hard-coding the name "lid" and labels "en","es", or "lr", user should be able to pass something like --positive-labels en es at runtime and the script should take care of anonymizing all other labels to more generic labels like other0, other1, ... To generalize to future tasks.

@keighrim keighrim force-pushed the 79-modernize-timeframelabeling branch from d87b3fd to 3aa163e Compare November 28, 2025 10:44
@keighrim
Copy link
Member

I updated the script with minor updates mentioned above (c6ccffc) . Still using --task and hard-coded names.
I re-ran the script on ambernet, SB preds and pushed new results under TF directory. @Brendayy I don't understand why you picked a completely arbitrary and new directory name to push the report the other day, but I deleted that commit. Please keep things organized.

@keighrim keighrim merged commit 0a1c8a4 into main Nov 28, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in infra Nov 28, 2025
@keighrim keighrim deleted the 79-modernize-timeframelabeling branch November 28, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

_modernize_ timeframe-labeling evaluation with common package

3 participants